Topology2: add missing topologies #10465
Conversation
Add sof-ptl-rt711 topologies with different dmic numbers. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Add PTL mockup topologies Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
add NVL mockup topologies Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
There was a problem hiding this comment.
Pull request overview
This PR adds missing topology configurations for ACE3 (Panther Lake/PTL) and ACE4 (Nova Lake/NVL) platforms. The changes include mockup topologies for testing and production configurations for RT711 codec variants with different channel configurations.
Key Changes:
- Added three mockup topology configurations for both PTL and NVL platforms
- Added RT711 topology configurations with 2-channel and 4-channel DMIC support for PTL platform
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/topology/topology2/production/tplg-targets-ace3.cmake | Added mockup topologies and RT711 codec configurations (2ch/4ch) for PTL platform |
| tools/topology/topology2/production/tplg-targets-ace4.cmake | Added mockup topologies for NVL platform matching PTL configurations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| # Array of "input-file-name;output-file-name;comma separated pre-processor variables" | ||
| list(APPEND TPLGS | ||
| # MOCKUP topology for PTL |
There was a problem hiding this comment.
why are these mockup? Looks like actual codec topologies to me
There was a problem hiding this comment.
Because we reuse the file name in the mockup configs. Like
{
.link_mask = GENMASK(3, 0),
.links = sdw_mockup_headset_2amps_mic,
.drv_name = "sof_sdw",
.sof_tplg_filename = "sof-ptl-rt711-rt1308-rt715.tplg",
},There was a problem hiding this comment.
Ahh yes. I forget this every single time.
There was a problem hiding this comment.
@bardliao I do wonder should we keep having the mocks for every gens going forward in upstream? Do these still serve a purpose in upstream?
Given these are upstream Linux, ok to add the topologies if only for consistency (topologies referenced by upstream Linux kernel should be available in SOF tplg upstream).
There was a problem hiding this comment.
The mockup config is usually used before the real SDW codec is setup. It is useful to verify the SDW bus driver. I do have 2 opens.
- Do we want to reuse the existing topologies? Given that we will use function topology in most case, we will need to create new topologies for the mockup configs. Is it better to create mockup topologies in the development folder? We can include SDW configs in the mockup topologies and then it will be platform independent. IOW, we just need to create a set of mockup topologies.
- Do we want to create mockup configs for every platform? Or just create mockup configs when the audio IP is changed? Like ACE3 -> ACE4.
|
|
||
| # Array of "input-file-name;output-file-name;comma separated pre-processor variables" | ||
| list(APPEND TPLGS | ||
| # MOCKUP topology for PTL |
There was a problem hiding this comment.
this would be for NVL, but not important, context makes obvious
|
|
||
| # Array of "input-file-name;output-file-name;comma separated pre-processor variables" | ||
| list(APPEND TPLGS | ||
| # MOCKUP topology for PTL |
There was a problem hiding this comment.
@bardliao I do wonder should we keep having the mocks for every gens going forward in upstream? Do these still serve a purpose in upstream?
Given these are upstream Linux, ok to add the topologies if only for consistency (topologies referenced by upstream Linux kernel should be available in SOF tplg upstream).
4 participants
Add some missing topologies
Fixes: #10464