Allow PHP code to be included in the Phar template#111
Allow PHP code to be included in the Phar template#111martin-rueegg wants to merge 2 commits intotheseer:masterfrom
Conversation
a11df90 to
cb60ec1
Compare
|
I'd appreciate a PR for the 5.3/5.6 compatibility. I'm still pondering whether I want to extend the template mechanism. I'm not sure I see the point in this extension? You can already specify custom templates as well as custom variable placeholders. Why would one need a custom head and tail? |
What I meant is a version 2, that drops php 5.x compatibility altogether, raising the minimum required level to either 7.4 or event 8.2. I'm not sure, that this is what you'd want a PR to do, is it?
Yes, I guess it's solvable with a custom template. And honestly, right now I can't recall what was the issue. It had to do with the head (the tail was just an addition, since I was adding the head) and the bootstrapping. If you think it's not a good idea, I'm happy if you close the PR and I'll ask it to re-consider once I get back to the project where I was using it with a better use-case. |
No, you pointed out an issue with PHP 5.6 compatibility that I missed. It's really hard to restrict yourself back to 5.3 ;-p
I still can't see a good reason for the head/tail thing given that you have full control over the actual template as a whole. I believe to understand what the boostrap thing does but I also fail to see why one would want the have that? |
This PR allows to include PHP code in the resulting PHAR through new options
--head--tail--bootstrapRequires