This repository was archived by the owner on Apr 14, 2024. It is now read-only.
error return adjustment for client#32
Open
tbal999 wants to merge 3 commits intothecodingmachine:masterfrom
Open
error return adjustment for client#32tbal999 wants to merge 3 commits intothecodingmachine:masterfrom
tbal999 wants to merge 3 commits intothecodingmachine:masterfrom
Conversation
Contributor
|
Hello @tbal999, I alas don't have time to maintain this client, so no ETA for a review / merge / release.. |
Author
|
no worries/rush gulien - just forked it & it's working fine for my use case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sometimes you get:
failed to generate the result PDFin func (c *Client) StoreContext(ctx context.Context, req Request, dest string) error
when you shouldn't.
I.E when the server is still processing a file.
so I did the below in a fork
https://github.com/tbal999/gotenberg-go-client/blob/48b3dc83b02f25f223a06bed4dc8cd51a2c18f60/client.go#L140
and it fixed the issue by returning an error & status if the status is an error.
could you please consider this PR.
thanks