Feat: add GET /auth/finance/ebitda endpoint#5
Open
mukama wants to merge 2 commits intotetherto:developfrom
Open
Feat: add GET /auth/finance/ebitda endpoint#5mukama wants to merge 2 commits intotetherto:developfrom
mukama wants to merge 2 commits intotetherto:developfrom
Conversation
Add EBITDA API endpoint that aggregates pool transactions, power/hashrate data, BTC prices, production costs, and block data to calculate selling and HODL EBITDA metrics with period-based aggregation. Includes shared infrastructure: period.utils, constants, and utility functions required for finance endpoints.
- Remove block data RPC call and processBlockData (not in spec) - Remove blockCount, difficulty, ebitdaMarginSelling, ebitdaMarginHodl from log - Fix processCostsData to handle flat objects from globalDataLib with daily costs - Replace direct globalDataLib.getGlobalData range query with getProductionCosts helper - Add site query param to schema, cache key, and handler for site-specific costs
tekwani
reviewed
Feb 14, 2026
| req.query.start, | ||
| req.query.end, | ||
| req.query.period, | ||
| req.query.site |
Contributor
There was a problem hiding this comment.
site param is not needed as data is being fetched for a single site.
| const { testModuleStructure, testHandlerFunctions, testOnRequestFunctions } = require('../helpers/routeTestHelpers') | ||
| const { createRoutesForTest } = require('../helpers/mockHelpers') | ||
|
|
||
| const ROUTES_PATH = '../../../workers/lib/server/routes/finance.routes.js' |
Contributor
There was a problem hiding this comment.
include in integration test as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /auth/finance/ebitdaendpoint with daily EBITDA calculations (revenue minus costs)periodparam for daily/monthly/yearly aggregationsiteparam for site-specific production costsExample Queries
Monthly (default):
Daily:
Yearly: