Skip to content

Conversation

@tconley1428
Copy link

What was changed

Why?

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@tconley1428 tconley1428 requested a review from wolfy-j as a code owner January 28, 2026 18:46
@vercel
Copy link

vercel bot commented Jan 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
php Ready Ready Preview, Comment Jan 28, 2026 6:47pm

Request Review

@xepozz
Copy link
Collaborator

xepozz commented Jan 29, 2026

Hi @tconley1428
Wouldn't you like to update old versions instead?

@tconley1428
Copy link
Author

It wasn't clear to me that this docker-compose was still being used as it has no references in the repo that I could find. If it is still relevant, yes. If it is, it should be updated like this:
temporalio/sdk-core#1103

@xepozz
Copy link
Collaborator

xepozz commented Jan 30, 2026

It wasn't clear to me that this docker-compose was still being used as it has no references in the repo that I could find. If it is still relevant, yes. If it is, it should be updated like this: temporalio/sdk-core#1103

I remembered the one place: https://learn.temporal.io/getting_started/php/hello_world_in_php/, but it points to https://github.com/temporalio/samples-php/blob/master/docker-compose.yml, which also could be updated.

Maybe this compose file is also pointed from somewhere, but I'd add instructions how to run tests with docker instead of deleting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants