update samples to use environment configuration for client #233
Conversation
THardy98
force-pushed
the
update_samples_env_config
branch
3 times, most recently
from
a92c84f to
df18612
Compare
activity_worker/activity_worker.py
Outdated
| config = ClientConfig.load_client_connect_config( | ||
| config_file=str(get_temporal_config_path()) | ||
| ) | ||
|
|
There was a problem hiding this comment.
Pedantic, but probably don't need this blank line in every sample
THardy98
force-pushed
the
update_samples_env_config
branch
from
a3daf44 to
136e3fc
Compare
THardy98
force-pushed
the
update_samples_env_config
branch
from
d9c0f98 to
fd5b254
Compare
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
Looks great to me. Holding off approving for same reason as at temporalio/samples-go#421 (review), not sure we want to tell everyone in all samples to use this yet. But an equivalent of temporalio/samples-go#420 that has advanced env config + just updating one may make sense for now.
* Update SDK version to 1.18 * Update openai breaking change
THardy98
force-pushed
the
update_samples_env_config
branch
from
fccf464 to
f2dd3d3
Compare
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
I trust we at least ran a sample or two to make sure they still work
Yup ran a basic sample, nexus sample (sets namespace as well), custom metric/data converter (sets runtime/data converter) and context propagation (sets interceptor). Works fine |
What was changed
Update samples to use environment configuration for clients.
Why?
Client environment configuration is intended as the preferred way to configure clients going forward.
Closes [Feature Request] Environment configuration #178
How was this tested:
Existing tests.
Any docs updates needed?
No