Skip to content

STYLE: fix violation of the DRY principle #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dandavison merged 1 commit into from
Dec 10, 2024
Merged

STYLE: fix violation of the DRY principle #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 11 additions & 28 deletions hello/hello_activity_choice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,39 +59,22 @@ async def run(self, list: ShoppingList) -> str:
ordered: List[str] = []
for item in list.items:
Copy link
Contributor

@dandavison dandavison Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tiny thing, not related to this PR, but we should avoid using list as a variable name in Python.

if item.fruit is Fruit.APPLE:
ordered.append(
await workflow.execute_activity(
order_apples,
item.amount,
start_to_close_timeout=timedelta(seconds=5),
)
)
order_function = order_apples
elif item.fruit is Fruit.BANANA:
ordered.append(
await workflow.execute_activity(
order_bananas,
item.amount,
start_to_close_timeout=timedelta(seconds=5),
)
)
order_function = order_bananas
elif item.fruit is Fruit.CHERRY:
ordered.append(
await workflow.execute_activity(
order_cherries,
item.amount,
start_to_close_timeout=timedelta(seconds=5),
)
)
order_function = order_cherries
elif item.fruit is Fruit.ORANGE:
ordered.append(
await workflow.execute_activity(
order_oranges,
item.amount,
start_to_close_timeout=timedelta(seconds=5),
)
)
order_function = order_oranges
else:
raise ValueError(f"Unrecognized fruit: {item.fruit}")
ordered.append(
await workflow.execute_activity(
order_function,
item.amount,
start_to_close_timeout=timedelta(seconds=5),
)
)
return "".join(ordered)


Expand Down
Loading