Skip to content

Conversation

@gpaoloni
Copy link
Collaborator

@gpaoloni gpaoloni commented Jan 14, 2026

Description

This PR introduces CI action for aselo-webchat-react-app to, "on push"

  • Run lint.
  • Run tests.
  • Build and upload artifact to the assets buckets.

NOTE: CI is failing cause tests are broken. That's fixed in #3829.

Checklist

Verification steps

  • Check CI including new jobs.
  • Check the artifact is uploaded to the bucket.

AFTER YOU MERGE

  1. Cut a release tag using the Github workflow. Wait for it to complete and notify in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

@gpaoloni gpaoloni changed the base branch from master to gian_CHI-3613-lint January 16, 2026 14:44
@gpaoloni gpaoloni changed the title chore: add CI job for aselo-webchat-react-app chore: aselo-webchat-react-app - add CI job for [CHI-3613] Jan 16, 2026
@gpaoloni gpaoloni marked this pull request as ready for review January 21, 2026 17:36
@gpaoloni gpaoloni requested a review from stephenhand January 21, 2026 17:36
Copy link
Collaborator

@stephenhand stephenhand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Maybe comment out the unit test runner while they are failing? Don't like merging failing PRs, though I guess it's ok if you merge the follow up right after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants