fix: update threading execution to use newTdSql instance

[tomchon]

https://project.feishu.cn/taosdata_td/defect/detail/6798991800

[gemini-code-assist]

Summary of Changes

Hello @tomchon, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a potential concurrency issue in the test framework's SQL execution by ensuring that each thread operates with its own dedicated SQL connection instance. This change enhances the robustness and reliability of multi-threaded data ingestion tests, preventing conflicts and unexpected behavior that could arise from shared resources.

Highlights

• Threading Execution Update: Modified the genMultiThreadSeq function to ensure each thread uses a new instance of tdSql by calling tdCom.newTdSql() before executing SQL queries. This prevents potential issues with shared tdSql instances across threads.
• Dependency Import: Added an import for tdCom from new_test_framework.utils to facilitate the creation of new tdSql instances for threading.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• test/cases/06-DataIngestion/01-SQL/test_write.py
  • Imported tdCom from new_test_framework.utils.
  • Removed an unnecessary blank line.
  • Updated genMultiThreadSeq to create a new tdSql instance for each thread's SQL execution.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses a potential concurrency issue in genMultiThreadSeq by creating a new tdSql instance for each thread. This prevents state sharing and potential race conditions that could occur when using a single shared instance. The fix is sound and improves the robustness of the concurrent tests. I have one suggestion to further improve the code by making it more concise.

[gemini-code-assist]

For better readability and conciseness, you can refactor this function to use a list comprehension. This is a more idiomatic Python approach for creating lists.

Suggested change

	tlist = list()
	for insert_sql in sql_list:
	t = threading.Thread(target=tdSql.execute, args=(insert_sql,))
	new_sql = tdCom.newTdSql()
	t = threading.Thread(target=new_sql.execute, args=(insert_sql,))
	tlist.append(t)
	return tlist
	return [threading.Thread(target=tdCom.newTdSql().execute, args=(insert_sql,)) for insert_sql in sql_list]

[Copilot]

Pull request overview

This PR updates the SQL ingestion concurrency test to avoid sharing the global tdSql instance across threads by creating a fresh TDSql client per thread via tdCom.newTdSql().

Changes:

• Import tdCom from new_test_framework.utils to access newTdSql().
• Update genMultiThreadSeq() to create a per-thread newTdSql instance and run execute() on that instance instead of the global tdSql.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

tdCom.newTdSql() creates a new cursor/connection wrapper, but the instance is never closed. Since one newTdSql is created per thread, this can leak resources across the test run. Consider moving newTdSql() creation into the thread target and ensuring close() is called in a finally block (or otherwise retain references so you can close them after join()).

[Copilot]

There is trailing whitespace at the end of the import line; please remove it to avoid noisy diffs and potential style/lint failures.