fix: add g++ to the base-builder dependencies in DockerfileTDgpt.base#34546
fix: add g++ to the base-builder dependencies in DockerfileTDgpt.base#34546
Conversation
Summary of ChangesHello @tomchon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a build dependency by incorporating the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull request overview
Adds the C++ compiler to the Docker “base-builder” stage so Python dependencies with native C/C++ extensions can build successfully during image creation.
Changes:
- Install
g++alongsidegccin thebase-builderapt dependencies.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request correctly adds g++ to the build dependencies in DockerfileTDgpt.base to support the compilation of Python packages with C++ extensions. I've provided a suggestion to further improve this by using the build-essential meta-package, which is a more robust and idiomatic approach for installing build-time dependencies in a Dockerfile.
| ARG ARCH=amd64 | ||
| RUN apt-get -o Acquire::Check-Valid-Until=false -o Acquire::Check-Date=false update -y && \ | ||
| apt-get install -y --no-install-recommends gcc libc-dev procps && \ | ||
| apt-get install -y --no-install-recommends gcc g++ libc-dev procps && \ |
There was a problem hiding this comment.
For better maintainability and to ensure all common build tools are present, it's recommended to use the build-essential meta-package instead of listing gcc and g++ individually. The build-essential package includes gcc, g++, make, and other necessary build tools (like libc-dev), making the build stage more robust for Python packages that might have varied native extension build requirements.
apt-get install -y --no-install-recommends build-essential procps && \
…ackage installation
No description provided.