Skip to content

fix(client/http): working reconnect with graceful shutdown#795

Open
m-hilgendorf wants to merge 6 commits intomainfrom
fix/reconnect
Open

fix(client/http): working reconnect with graceful shutdown#795
m-hilgendorf wants to merge 6 commits intomainfrom
fix/reconnect

Conversation

@m-hilgendorf
Copy link
Contributor

  • Refactor Client::send to accept a closure to rebuild requests during retry.
  • Lift re-connection logic out of service and place into Client::try_send
  • Wrap re-connection in a tangram_futures::retry::retry
  • Return a ServiceError::Disconnect when the client connection is closed or a ConnectionReset error occurs
  • Add test for remote build with server restart
  • Add --directory and --url options to CLI test harness

The bulk of the changes are in client/src/http.rs, in the implementation of Client::service, Client::ensure_connected, Client::try_send, and Client::send.

@m-hilgendorf m-hilgendorf requested a review from nitsky January 26, 2026 19:42
@nitsky nitsky added this to Roadmap Jan 26, 2026
@nitsky nitsky moved this to Under Review in Roadmap Jan 26, 2026
@nitsky nitsky force-pushed the fix/reconnect branch 2 times, most recently from 4e67697 to 8a45087 Compare January 27, 2026 13:53
@nitsky nitsky moved this from Under Review to In Progress in Roadmap Jan 29, 2026
@nitsky nitsky moved this from In Progress to On Deck in Roadmap Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: On Deck

Development

Successfully merging this pull request may close these issues.

2 participants