Fix missing Allow LAN access toggle #735
Conversation
…der than android 13 - API 33 Signed-off-by: Pawloland <59684145+Pawloland@users.noreply.github.com>
|
@kari-ts @barnstar @nickoneill @bradfitz, |
|
Some initial thoughts: |
|
It is possible to use exclude route method for supported android versions, but since it doesn't work for all of them supported by tailscale app, and manual approach does work for all, I thought it is better to stop using it everywhere, to avoid confusion. Regarding route explosion, I am not sure what it means. Do you mean having too many of addresses printed out in logcat, instead of just the count of them? I suppose I can remove logging them, but it was usefull when comparing with the tool I mentioned in linked issue. The algorithm for calculating the CIDR ranges tries to create minimal number of them, with smallest possible masks, to cover the whole allowed address space. About tests, I don't know how, since the code is in go aar, not in kotlin. I saw that the makefile has a target to run android code tests with Gradle but that doesn't cover go code, correct? |
Fix missing Allow LAN access toggle when exit node is activated for all devices older than android 13 - API 33.
Instead of relying on android SDK, manually calculate required ranges.
Fixes tailscale/tailscale#16187