-
Notifications
You must be signed in to change notification settings - Fork 1
refactor: improve toast apis and internals #660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ovitrif
wants to merge
17
commits into
master
Choose a base branch
from
refactor/toast
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+925
−626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ToastText sealed interface for type-safe messages - Create Toaster singleton with convenience APIs - Move ToastType to top-level with @stable annotation - Migrate all ViewModels and Repos to use Toaster - Delete ToastEventBus in favor of DI pattern Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add ToastText() factory constructors (invoke operators) - Remove redundant @stable from ToastType enum and value classes - Rename titleRes/bodyRes → title/body in @stringres overloads - Rename warning() → warn() across all overloads - Update all call sites for the API changes Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace ToastText.Literal() and ToastText.Resource() calls with the cleaner ToastText() factory constructor. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the toast system to improve architecture, naming, testability, and localization.
Description
Architecture Changes
ToastEventBussingleton with injectableToasterthat emits events viaSharedFlowToastTextsealed interface for type-safe toast messages (string resource vs raw string)ToastTypeenum to top-levelToastervia dependency injectionAPI Improvements
descriptionparameter tobodyacross all toast APIsvisibilityTime: Longtoduration: Durationusing Kotlin's type-safe Duration APIContextdependency fromToaster- string resolution happens inToastContentcomposableToasterviaCompositionLocalfor direct access in composableswarning()→warn()for consistencyAPI Prettification
ToastText()factory constructors via companion objectinvokeoperatorstitleRes/bodyRes→title/bodyin @stringres overloads (cleaner API)@Stableannotations fromToastTypeenum and value classes (inferred by Compose)Localization & @stringres Support
@StringResoverloads toToaster(type-safe string resource IDs)ToastTextoverloads for mixed resource/literal casesToastText.asString()composable extension usingstringResource()@StringResoverloads (fixes LocalContext lint warnings)@StringResoverloadsInternal Refactoring
ToastQueueManagertoToastQueueand refactors it to inherit fromBaseCoroutineScopeToastViewtoToastContent(private) andToastOverlaytoToastHost(public API)Documentation & Testing
*Managerclass naming anti-patternToastQueuebehavior (9 test cases)API Examples
Preview
N/A - Internal refactoring with no visible changes.
QA Notes
1. Toast Functionality
2. Toast Queue Behavior
3. Drag Interactions
4. Localization
5. Regression Testing