Skip to content

Conversation

@ovitrif
Copy link
Collaborator

@ovitrif ovitrif commented Jan 11, 2026

Integrates:

This PR removes the dependency on LDK from the migration code by using the new deriveNodeSecretFromMnemonic function exposed by ldk-node instead.

Description

  • Removes the bundled LDK-release.aar library (~18MB) which was only used for key derivation during RN migration
  • Replaces complex manual BIP39/BIP32 seed derivation with the simpler deriveNodeSecretFromMnemonic function from ldk-node
  • Removes reflection-based access to get_node_secret_key which was fragile
  • Consolidates duplicate toHex implementations by using the shared extension function
  • Updates ldk-node-android to v0.7.0-rc.3

Preview

N/A - No UI changes

QA Notes

  • Tested with regtest RN app and regtest debug build of Bitkit Android.
  • Tested with prod RN app and mainnet release build of Bitkit Android.

Tests:

1. Migration from RN

  1. Install RN Bitkit and setup with a funded wallet
  2. In build.gradle.kts:65 clear the string for applicationIdSuffix
    It should be: applicationIdSuffix = ""
  3. Install this build over RN app
  4. Verify migration completes successfully

@ovitrif ovitrif marked this pull request as draft January 11, 2026 21:38
@claude

This comment has been minimized.

@ovitrif ovitrif force-pushed the refactor/remove-ldk-dependency branch from 123d173 to eb48e90 Compare January 11, 2026 22:02
@ovitrif ovitrif self-assigned this Jan 11, 2026
@ovitrif ovitrif marked this pull request as ready for review January 11, 2026 22:37
@ovitrif ovitrif changed the title refactor: remove LDK dependency from migration refactor: remove dependency on LDK Jan 11, 2026
@claude

This comment was marked as outdated.

2 similar comments
@claude

This comment was marked as outdated.

@claude

This comment was marked as outdated.

@jvsena42
Copy link
Member

LGTM, I'll test it when the conflicts are solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants