Skip to content

Conversation

@xhalo32
Copy link

@xhalo32 xhalo32 commented Jul 6, 2024

Previously, parsedVersionSpec was passed to NPMRegistrySource.prototype.fetch which stripped the alias if the versionSpec also contained a semver range, like npm:@codingame/monaco-vscode-api@ >= 1.69.0 < 1.70.0.

This change removes the semver parsing from Source.constructSource as it is the rensponsibility of NPMRegistrySource.prototype.fetch.

Fixes #331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Source.constructSource passes wrong versionSpec to NPMRegistrySource in case of aliased package name

1 participant