Gui fixes for ScatterView#35
Merged
dyfer merged 3 commits intosupercollider-quarks:masterfrom Apr 18, 2022
Merged
Conversation
make help examples (ScatterView, ScatterView2, ScatterView3d) work under recent SuperCollider.
examples from help now plot identical to old Cocoa gui version. tested with sc3.3.1
also whitespace cleanup and two .memStore -> .add
dyfer
approved these changes
Apr 17, 2022
Contributor
dyfer
left a comment
dyfer
left a comment
There was a problem hiding this comment.
I've run these examples on SC 3.12. Looks good, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is similar to #30 but does not touch anything except the ScatterView and one GUI example in Guides/rewriteString.schelp.
The coordinate system is also adjusted to make up for the removal of relativeOrigin. All ScatterView examples now plot identical to the old CocoaGUI version (SC3.3.1 OSX Cocoa).
(SC3.12.2 macOS Qt)
The
ERROR: Message 'selectIndex' not understood.in the ScatterView2 help example is also present in the old CocoaGUI, so for now i left it as is.