Skip to content

2 pointers-1 completed#1824

Open
melvinmilkiyas wants to merge 1 commit intosuper30admin:masterfrom
melvinmilkiyas:master
Open

2 pointers-1 completed#1824
melvinmilkiyas wants to merge 1 commit intosuper30admin:masterfrom
melvinmilkiyas:master

Conversation

@melvinmilkiyas
Copy link

No description provided.

@super30admin
Copy link
Owner

  • Strengths:

    • Good understanding of the problems and their solutions.
    • Efficient use of two-pointer techniques where applicable.
    • Clear and concise code structure.
  • Areas for Improvement:

    • In sort-colors.py, consider using the two-pointer approach as it is more efficient for this specific problem and aligns better with the problem's intent.
    • In 3-sum.py, correct the condition for skipping duplicates to if l>ind+1 and nums[l]==nums[l-1] to ensure all valid triplets are considered.
    • Improve comments and variable naming for better readability. For example, arr in sort-colors.py could be named counts to be more descriptive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants