Skip to content

Adding problem with binary search pattern#2298

Open
jose-rafael-marcano wants to merge 1 commit intosuper30admin:masterfrom
jose-rafael-marcano:master
Open

Adding problem with binary search pattern#2298
jose-rafael-marcano wants to merge 1 commit intosuper30admin:masterfrom
jose-rafael-marcano:master

Conversation

@jose-rafael-marcano
Copy link

No description provided.

@super30admin
Copy link
Owner

  • Strengths:
    • The implementation of the binary search for finding the first and last positions is correct and efficient.
    • The code is well-commented and easy to follow.
    • The inclusion of test cases in the main method is a good practice for verifying correctness.
  • Areas for Improvement:
    • Correct the space complexity in the comments from O(n) to O(1) since no additional space is used.
    • Ensure consistency in the comments regarding time complexity (the student initially mentions O(n) but later correctly states O(log n)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants