Skip to content

Completed BinarySearch2#2292

Open
JainShubham23 wants to merge 1 commit intosuper30admin:masterfrom
JainShubham23:master
Open

Completed BinarySearch2#2292
JainShubham23 wants to merge 1 commit intosuper30admin:masterfrom
JainShubham23:master

Conversation

@JainShubham23
Copy link

No description provided.

@super30admin
Copy link
Owner

  • Strengths:
    • The logic for finding the first and last occurrences is correctly implemented using binary search.
    • The code is modular and easy to follow.
    • Edge cases are handled appropriately.
  • Areas for Improvement:
    • Remove the 'self' parameter from the helper functions since they are not class methods.
    • Consider adding comments to explain the binary search logic more clearly, especially for the conditions that check for the first and last occurrences.
    • The variable names could be more descriptive (e.g., 'l' and 'r' could be 'left' and 'right').

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants