Fix tooltip alignment logic and removed hover blockage #4809 #4851
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
js/toolbar.js
Outdated
| console.log("Tooltip override block REACHED!"); | ||
| const icons = Array.from(document.querySelectorAll('.tooltipped')); | ||
| const right_icons = Array.from(document.querySelectorAll('ul.main.right a')); | ||
| const left_below_icons = Array.from(document.querySelectorAll('ul.aux.ledt a')); |
index.html
Outdated
| </li> | ||
| <li> | ||
| <a id="stop" class="left tooltipped"><i class="material-icons main">stop</i></a> | ||
| <a id="stop" class="left tooltipped"><i class="material-icons main ">stop</i></a> |
There was a problem hiding this comment.
why are you adding the space?
|
Can you be clear about what changes in the UX from this PR? |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
Earlier tooltips used to have a fixed position. As a result:
With this modification:
In general, this results in a cleaner, easier-to-use, and less annoying user interface, particularly when interacting with closely spaced buttons. Also, Some changes in the diff are due to automatic code formatting applied by my IDE. |
|
I believe this is too much for something as simple as tooltips. |
3 participants
This PR fixes incorrect tooltip placement by
Fixes #4809