Add sorobanTxs field to transaction information and expose unsafeApi parameter#113
Open
Add sorobanTxs field to transaction information and expose unsafeApi parameter#113
Conversation
Contributor
Coverage reportCaution Test run failed
Test suite run failedFailed tests: 1/72. Failed suites: 1/8.Report generated by 🧪jest coverage report action from 55c651c |
stwiname
reviewed
Mar 23, 2025
| ): Promise<StellarApiService> { | ||
| let network: StellarProjectNetworkConfig; | ||
|
|
||
| const needSorobanTxMeta = !!project.dataSources.find( |
Contributor
There was a problem hiding this comment.
This needs to take into account project upgrades and dynamic datasoruces.
Does the user requesting this feature also need to access the transactions from soroban events?
| /** | ||
| * Need soroban meta data | ||
| */ | ||
| sorobanTxMeta?: boolean; |
Contributor
There was a problem hiding this comment.
I think this should be determined based on the project datasources not on a user setting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add sorobanTxs field to transaction information and expose unsafeApi parameter
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist