Prototype creation#2
Open
apendua wants to merge 1 commit intosubhog:masterfrom
apendua:prototype-creation
Open
Prototype creation#2apendua wants to merge 1 commit intosubhog:masterfrom apendua:prototype-creation
apendua wants to merge 1 commit intosubhog:masterfrom
apendua:prototype-creation
Conversation
Author
|
If you're afraid to use var f = function(){};
f.prototype = parent.prototype;
child.prototype = new f;or even this ;) child.prototype = { __proto__: parent.prototype };These are all equivalents of child.prototype = Object.create(parent.prototype); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it is a batter way to do it ;)
No instance of tha parent parent should be created here, since it is a premature stage. Imagine a generic manager class (this is exactlly the problem I had experienced), which specializes to some different kind of managers. To me, calling a manager constructor with no data attached did not make any sense, so using an instance of base class as a prototype of the child was not possilbe. Instead, one should use the prototype of the base class - that's what is it for.