Alter force_encoding from ISO-8859-1 to UTF-8#57
Open
boboism wants to merge 1 commit intostreamio:masterfrom
Open
Alter force_encoding from ISO-8859-1 to UTF-8#57boboism wants to merge 1 commit intostreamio:masterfrom
boboism wants to merge 1 commit intostreamio:masterfrom
Conversation
…with non English meta(say like Chinese
Collaborator
|
I'm hesitant to merge this as there is no spec for the current handling of ISO-8859-1. And UTF-8 characters should actually work just fine. If you have problems the Chinese characters are probably using a different encoding all together. The original fix was added in e424d8f. Would be nice if we could find a way to properly spec out what's going on... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dears,
I have change transcoder#fix_encoding output encoding from ISO-8859-1 to UTF-8 while handling video with non English meta(say like Chinese).
My Video Meta as follow: