Subtitle metadata reading support#173
Open
bradcordeiro wants to merge 4 commits intostreamio:masterfrom
bradcordeiro:subtitle-support
Open
Subtitle metadata reading support#173bradcordeiro wants to merge 4 commits intostreamio:masterfrom bradcordeiro:subtitle-support
bradcordeiro wants to merge 4 commits intostreamio:masterfrom
bradcordeiro:subtitle-support
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added some attr_readers to the Movie class to make subtitle metadata a bit easier to access, as well as the code to assign that metadata to the underlying variables.
I also included tests and a new fixture (based on an existing one) for the tests.