Add useArrayTheory option, conditionally lower Core's Map operations to SMT Array#441
Open
aqjune-aws wants to merge 3 commits intomainfrom
Open
Add useArrayTheory option, conditionally lower Core's Map operations to SMT Array#441aqjune-aws wants to merge 3 commits intomainfrom
aqjune-aws wants to merge 3 commits intomainfrom
Conversation
aqjune-aws
commented
Feb 17, 2026
| .ok (.app (Op.uf uf), smt_outty, ctx) | ||
| else | ||
| .ok (.app (Op.uf uf), smt_outty, ctx) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This change looks big, but in fact most of these lines are due to indentations. Turn on "Hide whitespace" on Github diff page and this diff will disappear.
shigoel
reviewed
Feb 17, 2026
Contributor
shigoel
left a comment
shigoel
left a comment
There was a problem hiding this comment.
LGTM in general, but would you be up for adding a test for a Core program that uses Maps to see how well it works using the Array theory? Perhaps https://github.com/strata-org/Strata/blob/main/StrataTest/Languages/Core/Examples/AdvancedMaps.lean?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
useArrayTheoryoption that conditionally lowers theselectandupdateoperations in Core (map_getandmap_setrules in Core DDM) to SMT-LIB's Array theory operations.Lots of helps from Kiro.
This pull request has overlapping edits with #414.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.