Open
Conversation
aqjune-aws
reviewed
Feb 17, 2026
Contributor
aqjune-aws
left a comment
aqjune-aws
left a comment
There was a problem hiding this comment.
The directory name 'old_expected' doesn't seem to convey much information other than it is old. What about expected-nonlaurel and expected-laurel?
|
|
||
| # Initialize conda | ||
| eval "$(conda shell.bash hook)" | ||
| conda activate strata |
Contributor
There was a problem hiding this comment.
conda is not available on my machine - can we run this test without conda?
I think it is good to merge this script with run_py_analyze.sh because the boilerplate lines are equivalent.
| (Origin_test_helper_procedure_Requires)req_name_is_foo: 🟡 unknown (at byte 10641) | ||
| (Origin_test_helper_procedure_Requires)req_opt_name_none_or_str: ✅ pass (at byte 10690) | ||
|
|
||
| (Origin_test_helper_procedure_Requires)req_opt_name_none_or_bar: ✅ pass (at byte 10836) |
Contributor
There was a problem hiding this comment.
Do you have idea why the output messages disappeared in this test case?
And the StrataTest/Languages/Python/expected/test_missing_models.expected case seems opposite. Are we having different procedure filtering policy compared to the old Python translator?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python -> Laurel translation.
This includes a new
TCoretype in Laurel to directly refer to Core types. For now the benchmarks don't work with CVC5.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.