Skip to content

Restructure Draft XML Generator UI and Workflow #104

Merged
AussieScorcher merged 1 commit intomainfrom
refactor/xml-generator-restructure
Feb 14, 2026
Merged

Restructure Draft XML Generator UI and Workflow #104
AussieScorcher merged 1 commit intomainfrom
refactor/xml-generator-restructure

Conversation

@llamavert
Copy link
Contributor

Summary

Restructures the XML generator page with a two-column layout featuring map preview and sidebar controls.

Changes Made

  • Replaced search-based workflow with auto-load functionality on mount, including automatic navigation redirects when airport data fails or no points exist
  • Restructured page layout to two-column grid with map in main area and airport statistics, settings panel, and download actions consolidated in sidebar
  • Added breadcrumb navigation linking back to map page and reset buttons for padding and altitude settings with default constant values
  • Introduced defaultElevation state to enable resetting altitude to airport's original elevation value
  • Updated messaging across contribution pages for clarity (Contact toast, ContributeMap warnings, ContributionDashboard description)
  • Enhanced info notice to better explain the draft nature of generated XML files and required manual adjustments
  • Changed XML filename format to use capitalized "Draft" suffix and added loading state with centered spinner
  • Cleaned up imports by removing unused components and adding useNavigate and Breadcrumb

Additional Information

Author Information

Discord Username:
VATSIM CID:


Checklist:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

- Replaced search-based workflow with auto-load on mount
- Restructured layout to two-column grid with map and sidebar
- Added breadcrumb navigation for better flow
- Added reset buttons for padding and altitude settings
- Improved error handling with navigation redirects
- Updated messaging across contribution pages
- Changed XML filename format to use capitalized "Draft"
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 13, 2026

Greptile Overview

Greptile Summary

Restructures the XML generator page from a search-based workflow to an auto-load pattern, replacing the search form with breadcrumb navigation and reorganizing the UI into a two-column grid layout with the map on the left and controls on the right.

Key Changes:

  • Removed search functionality in favor of automatic data loading on mount with navigation redirects for errors or empty data
  • Introduced breadcrumb navigation linking back to map page, and added reset buttons for padding and altitude settings
  • Restructured page layout to display map preview and sidebar controls side-by-side
  • Updated filename format to capitalize "Draft" suffix and improved info notice text
  • Enhanced messaging across multiple contribution pages for clarity

Issues Found:

  • Invalid Tailwind class h-150 used in XMLGenerator.jsx (should be h-[600px] or similar)

Confidence Score: 4/5

  • This PR is safe to merge with one minor syntax fix needed
  • The refactoring is well-structured with proper error handling and navigation redirects. The only issue is an invalid Tailwind class that needs correction before deployment to prevent styling issues.
  • src/pages/XMLGenerator.jsx requires attention for the invalid Tailwind class

Important Files Changed

Filename Overview
src/pages/XMLGenerator.jsx Restructured to auto-load on mount with two-column layout; invalid Tailwind class h-150 used
src/pages/Contact.jsx Minor toast message simplification, no issues found
src/pages/ContributeMap.jsx Improved clarity of warning and info messages, no issues found
src/pages/ContributionDashboard.jsx Updated description text for better clarity, no issues found

Last reviewed commit: b740ca2

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@AussieScorcher AussieScorcher merged commit cb2139a into main Feb 14, 2026
6 checks passed
@AussieScorcher AussieScorcher deleted the refactor/xml-generator-restructure branch February 14, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants