Skip to content

Add About page hero banner and improve division member error handling#103

Merged
AussieScorcher merged 3 commits intomainfrom
design/upgrade-about-visuals
Feb 12, 2026
Merged

Add About page hero banner and improve division member error handling#103
AussieScorcher merged 3 commits intomainfrom
design/upgrade-about-visuals

Conversation

@llamavert
Copy link
Contributor

Summary

This PR enhances the About page with including a new hero banner and fixes error handling when attempting to add duplicate members to divisions.

Changes Made

  • Added responsive hero banner image to the About page with gradient fade overlay
  • Updated "Where It Started" image links to open in new tabs with proper paths
  • Removed redundant "About" badge from page header for cleaner design
  • Implemented 409 conflict handling for duplicate division member additions with user-friendly warning toast
  • Fixed CSS class syntax error in TeamMemberCard component (changed !p-4 to p-4!)
  • Added 4 new image assets to public folder (AboutBanner.png, earliest-prototype.png, first-sim-renders.png, polished-plugin.png)

Additional Information

Author Information

Discord Username:
VATSIM CID:


Checklist:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

llamavert and others added 2 commits February 12, 2026 22:29
…dling

- Add hero banner image with fade overlay to About page
- Fix links to historical prototype images (now open in new tabs)
- Remove redundant "About" badge from page header
- Add 409 conflict handling for duplicate division member additions
- Fix CSS class syntax in TeamMemberCard component
@llamavert
Copy link
Contributor Author

@greptileai

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 12, 2026

Greptile Overview

Greptile Summary

This PR enhances the About page with a responsive hero banner and improves error handling for duplicate division members. The division management changes properly handle 409 conflict responses with user-friendly warning toasts. The About page updates include a new hero banner with gradient overlay, corrected image links for history section that now open in new tabs, and removal of the redundant "About" badge. Note that previous review threads have flagged CSS syntax issues in src/pages/About.jsx that remain unaddressed.

Confidence Score: 4/5

  • Safe to merge with minor CSS syntax issues already flagged in previous threads
  • The error handling logic in DivisionManagement is correctly implemented with proper 409 status handling. The About page changes are primarily visual enhancements with correct image paths and accessibility attributes. However, CSS syntax issues flagged in previous threads remain unaddressed, preventing a perfect score.
  • No files require special attention beyond addressing previously flagged CSS syntax issues

Important Files Changed

Filename Overview
src/pages/About.jsx Added hero banner with gradient overlay, updated image links, removed badge, but has syntax issues flagged in previous threads
src/components/divisions/DivisionManagement.jsx Properly handles 409 conflict status for duplicate members with warning toast

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@AussieScorcher
Copy link
Member

@greptileai

@AussieScorcher AussieScorcher merged commit 04cad5f into main Feb 12, 2026
6 checks passed
@AussieScorcher AussieScorcher deleted the design/upgrade-about-visuals branch February 12, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants