Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for the ipnetwork crate as an alternative to the existing ipnet crate dependency, addressing issue #28.
Changes:
- Refactored to support multiple IP network crate implementations via optional features
- Moved
ipnetimplementation to a separate module (src/ipnet.rs) - Added new
ipnetworkimplementation module (src/ipnetwork.rs) - Updated documentation examples to use doc test format
- Updated CI workflows to test with all features and maintain MSRV compatibility
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Made both ipnet and ipnetwork optional dependencies with feature flags, default to ipnet |
| src/lib.rs | Refactored to conditionally include implementation modules based on feature flags, updated documentation |
| src/ipnet.rs | New file containing the original ipnet implementation extracted from lib.rs |
| src/ipnetwork.rs | New file implementing support for ipnetwork types with custom truncation logic |
| .github/workflows/ci.yml | Updated CI to test all features on stable and maintain MSRV testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
af7406c to
05de8a5
Compare
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
|
Amazing! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28