Skip to content

Support ipnetwork#29

Merged
sticnarf merged 1 commit intomasterfrom
ipnetwork
Jan 16, 2026
Merged

Support ipnetwork#29
sticnarf merged 1 commit intomasterfrom
ipnetwork

Conversation

@sticnarf
Copy link
Owner

Closes #28

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the ipnetwork crate as an alternative to the existing ipnet crate dependency, addressing issue #28.

Changes:

  • Refactored to support multiple IP network crate implementations via optional features
  • Moved ipnet implementation to a separate module (src/ipnet.rs)
  • Added new ipnetwork implementation module (src/ipnetwork.rs)
  • Updated documentation examples to use doc test format
  • Updated CI workflows to test with all features and maintain MSRV compatibility

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Cargo.toml Made both ipnet and ipnetwork optional dependencies with feature flags, default to ipnet
src/lib.rs Refactored to conditionally include implementation modules based on feature flags, updated documentation
src/ipnet.rs New file containing the original ipnet implementation extracted from lib.rs
src/ipnetwork.rs New file implementing support for ipnetwork types with custom truncation logic
.github/workflows/ci.yml Updated CI to test all features on stable and maintain MSRV testing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sticnarf sticnarf force-pushed the ipnetwork branch 3 times, most recently from af7406c to 05de8a5 Compare January 16, 2026 15:36
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
@sticnarf sticnarf merged commit be70263 into master Jan 16, 2026
2 checks passed
@sticnarf sticnarf deleted the ipnetwork branch January 16, 2026 16:17
@pronebird
Copy link

Amazing! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Ipnetwork crate

2 participants