Upstreamxrdceph2 #42
Open
Upstreamxrdceph2 #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was noticed that for reads there may be some inefficiencies when xcache is involved. For writes, however, the buffering layer improved pefromance significantly. So, it make sense to introduce the write-only mode.
…streamed checksum. Settings for streamed checksum allow calculation only, calc+log, and calc+log+store as extended attribute. Record streamed and readback checksums in a central checksums.log file.
… log uninitialised checksum value when client reads file. Move recording of readback checksum value into XrdCephPosix instead of Set() method in XrdCephXAttr.cc. More checks for writable checksum record file
…er than using zlib directly Move from using zlib adler32() function to XrdCks/XrdCksCalcadler32. The superclass, XrdCksCalc, provides a uniform interface to all supported checksum algorithms, and is the preferred method in XRootD. Remove an unneccessary guard condition in the ceph_posix_*write() methods.
The XrdCksCalc object in the CephFileRef structure needs a matching delete in ceph_posix_close()
… as it would be too risky
…quests use strings instead of char * copies for streamed checksum code rebase config load to only check log file path if streamed checksum config is enabled remove duplicate extern declaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.