Image inherit from the basic Content type#144
Open
Sulfkain wants to merge 1 commit intostfalcon-studio:masterfrom
Sulfkain:patch-1
Open
Image inherit from the basic Content type#144Sulfkain wants to merge 1 commit intostfalcon-studio:masterfrom Sulfkain:patch-1
Sulfkain wants to merge 1 commit intostfalcon-studio:masterfrom
Sulfkain:patch-1
Conversation
Don't you think MessageContentType.Image should inherit from MessageContentType? why don't do it, if MessageContentType is the basic type?
|
Hello, considering that the library is not maintained and I actively use it, I have decided to fork it for the time being under the same name. Changes to naming and other practices will come in the future. In the mean time, I will look at your PR and consider merging it. I hope we can revive this project together. https://github.com/mario/chatkit Cheers, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't you think MessageContentType.Image should inherit from MessageContentType? why don't do it, if MessageContentType is the basic type?