ExpectedSystemExit improvement in multi-threads environment

[akryvtsun]

Implementation of #44 fix

[stefanbirkner]

Please delete this constructor because we don't need it anymore. It is only used by the test and you can use new NoExitSecurityManager(..., 0) instead.

[stefanbirkner]

I just saw that this was the case before your last commit. I suggest to revert your last commit because it does not improve the code in a way that I want. It adds another layer of abstraction by using a new type. I prefer simple code :-)

[stefanbirkner]

Nevertheless you can delete the old constructor.

[akryvtsun]

@stefanbirkner good point! agreed.

[akryvtsun]

Implemented your notes. Fixed FindBug warning.

[stefanbirkner]

You don't have to check statusOfFirstExitCall anymore. You can remove the second line and immediately return the result of line 36: return synchLatch.await(...). By the way could you rename syncLatch to exitLatch.

[akryvtsun]

@stefanbirkner agreed. Also it's possible to change type of statusOfFirstExitCall from Integer to simply int and remove if statement at all here:

    @Override
    public void checkExit(int status) {
        if (statusOfFirstExitCall == null)
            statusOfFirstExitCall = status;
        exitLatch.countDown();
        throw new CheckExitCalled(status);
    }

WDYT?

[stefanbirkner]

Don't catch that exception. By rethrowing it, the developer gets the full stacktrace of that exception which can be valuable. Additionally it is less code on our side.

[akryvtsun]

Agreed. Fixed.

[stefanbirkner]

We are getting closer to a final version of the pull request. Thank you for your patience.

[stefanbirkner]

Could you add the timeout as a parameter to the isCheckExitCalled method instead of using a field in that class.

[akryvtsun]

@stefanbirkner done

[akryvtsun]

@stefanbirkner you have to supprese Firebugs check for intentional ignoring return value in line exitStatusHolder.offer(status); somehow.

[akryvtsun]

Here is information how to do this
http://stackoverflow.com/questions/1829904/is-there-a-way-to-ignore-a-single-findbugs-warning