Merged
Conversation
Member
|
Sorry for late reply. It is best to use fallback compatibility for phpmicro patches to reduce duplicate patch files: if the patch for 80 is applicable to 80~83, only cli_static_80.patch is needed. I'll make adjustments later, thanks for contributing to the project! |
crazywhalecc
added a commit
that referenced
this pull request
Jul 15, 2025
* fix: 8.4 CLI on windows * Remove redundant patch files --------- Co-authored-by: crazywhalecc <jesse2061@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested here: #3 (comment),
php_win32_init_gettimeofday();no longer exists in PHP 8.4.You can find a working build here: https://github.com/SRWieZ/fork-nativephp-php-bin/actions/runs/12487358547/job/34848443622?pr=1.
Summary of changes
cli_staticto_80,_81,_82,_83