Skip to content

Conversation

Copy link

Copilot AI commented Jan 6, 2026

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

The cmdstan-tarball-check.yaml workflow has fallen out of sync with R-CMD-check.yaml due to separate maintenance. This PR consolidates them by adding optional custom tarball support to the main workflow via workflow_dispatch.

Changes:

  • R-CMD-check.yaml: Added workflow_dispatch trigger with optional tarball_url input. Installation logic now checks CMDSTAN_TEST_TARBALL_URL and uses custom tarball when provided:

    tarball_url <- Sys.getenv("CMDSTAN_TEST_TARBALL_URL")
    if (nzchar(tarball_url) && tarball_url != "latest") {
      cmdstanr::install_cmdstan(cores = 2, release_url = tarball_url)
    } else {
      cmdstanr::install_cmdstan(cores = 2)
    }
  • cmdstan-tarball-check.yaml: Updated to modern r-lib actions (setup-r@v2, setup-r-dependencies@v2, check-r-package@v2). Added deprecation notice. Logic aligned with main workflow.

  • .github/workflows/README.md: Documented manual workflow trigger process for custom tarball testing.

Usage: Navigate to Actions → "Unit tests" → "Run workflow", enter tarball URL (or leave empty for latest).

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
GitHub Copilot

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

Original prompt

This section details on the original issue you should resolve

<issue_title>CI: Update custom tarball action</issue_title>
<issue_description>We use this action during the CmdStan releases but it has fallen out of date. One good way to keep this in sync is to just update your normal unit testing action to optionally accept a custom version, that way you don't need to maintain things twice.</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 5 commits January 6, 2026 21:50
- Add workflow_dispatch with tarball_url input to R-CMD-check.yaml
- Set CMDSTAN_TEST_TARBALL_URL env var and update install_cmdstan step
- Update cmdstan-tarball-check.yaml to use modern actions and add deprecation notice

Co-authored-by: jgabry <7796803+jgabry@users.noreply.github.com>
Co-authored-by: jgabry <7796803+jgabry@users.noreply.github.com>
Both workflows now use the same logic: tarball URL is only used if it's
non-empty AND not equal to "latest". This ensures backwards compatibility
and consistent behavior.

Co-authored-by: jgabry <7796803+jgabry@users.noreply.github.com>
Changed required from true to false to match the main workflow's behavior
and provide consistent user experience.

Co-authored-by: jgabry <7796803+jgabry@users.noreply.github.com>
Changed legacy workflow default from 'latest' to empty string to match
the main workflow exactly, ensuring identical behavior.

Co-authored-by: jgabry <7796803+jgabry@users.noreply.github.com>
Copilot AI changed the title [WIP] Update custom tarball action for CmdStan releases CI: Consolidate custom tarball workflow into main unit test workflow Jan 6, 2026
Copilot AI requested a review from jgabry January 6, 2026 21:57
@jgabry
Copy link
Member

jgabry commented Jan 7, 2026

Closing, will use my version in #1132 instead.

@jgabry jgabry closed this Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: Update custom tarball action

2 participants