fix(ci): remove redundant binary rename step for Unix builds #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the release workflow failing on Linux with:
Problem
The
build-sea.jsscript already names Unix binaries with platform and architecture (e.g.,shield-linux-x64,shield-darwin-arm64). The subsequent rename step tried to rename them to the same name, causing themvcommand to fail.Solution
Remove the redundant rename step for Unix platforms. The Windows rename step is kept because
build-sea.jscreatesshield.exe(generic name) which needs to be renamed toshield-windows-x64.exe.Testing
build-sea.jscreates correctly-named binaries