Merged
Conversation
🦋 Changeset detectedLatest commit: 275eac0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for abort signals in the HTTP client and expands the set of recognized networks by introducing "katana" across schemas and mocks.
- Introduce
options?: { signal?: AbortSignal }incustomFetchand all generated API methods - Add
"katana"to all network-related schema constants and update MSW mocks - Update changelog to reflect abort signal support and schema changes
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/api/schemas/*Network.ts | Added "katana" to each network enum constant |
| src/api/index.ts | Extended API methods to accept an options parameter and pass through to customFetch |
| src/api/index.msw.ts | Updated MSW response mocks to include "katana" |
| src/api-client.ts | Modified customFetch signature to accept abort signals |
| .changeset/fluffy-ideas-speak.md | Added changelog entry for abort signal support |
Comments suppressed due to low confidence (2)
src/api/index.ts:32
- The JSDoc comment for this function should be updated to include the new 'options' parameter and describe its purpose for abort signal support.
export const getYields = (
src/api-client.ts:30
- Consider adding unit tests to verify that abort signals passed via the 'options' parameter are correctly forwarded to the fetch call and that requests can be aborted as intended.
signal: options?.signal,
Philippoes
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.