Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR updates the release workflow to remove the NPM_TOKEN secret and switch to OIDC-based authentication for npm publishing.
- Removes
NPM_TOKENby setting it to an empty string - Adds a comment explaining the change references a changesets GitHub issue
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -42,3 +42,6 @@ jobs: | |||
| commitMode: github-api | |||
| env: | |||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
There was a problem hiding this comment.
Setting NPM_TOKEN to an empty string may not be sufficient to enable OIDC authentication for npm publishing. The workflow has id-token: write permission (line 17), but there's no explicit configuration to set up npm to use OIDC provenance.
According to the changesets issue referenced, you typically need to configure npm authentication by creating an .npmrc file or setting NPM_CONFIG_PROVENANCE=true environment variable to enable OIDC-based publishing with provenance. Consider adding:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_CONFIG_PROVENANCE: trueOr ensure an .npmrc file is configured appropriately for OIDC authentication.
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
| NPM_CONFIG_PROVENANCE: true |
No description provided.