Conversation
🦋 Changeset detectedLatest commit: db7cffb The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the API schemas to remove legacy yield balances endpoints and add enhanced query capabilities, while also improving CI/CD workflow configuration and adding support for a new network type.
- Removes legacy yield balances endpoints and all related types, simplifying the API surface
- Adds new query parameters for multi-network, multi-type, multi-token, and multi-provider filtering
- Adds support for the "hyperevm" network across all schema files
Reviewed Changes
Copilot reviewed 27 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/api/schemas/yieldsControllerGetYieldsTypesItem.ts | Added new yield types enum for controller filtering |
| src/api/schemas/yieldsControllerGetYieldsSort.ts | Added new sorting options for yield status |
| src/api/schemas/yieldsControllerGetYieldsParams.ts | Enhanced with multiple new query parameters for filtering |
| src/api/schemas/yieldQueryDto.ts | Added new filtering and sorting capabilities |
| src/api/schemas/yieldQueryDtoSort.ts | Added sort options for yield queries |
| src/api/schemas/yieldQueryDtoTypesItem.ts | Added yield types enum for DTO |
| src/api/schemas/*.ts (network files) | Added "hyperevm" network support across all network enums |
| src/api/schemas/index.ts | Updated exports to remove legacy types and add new ones |
| src/api/index.ts | Removed legacy yield balances function and related types |
| src/api/index.msw.ts | Removed legacy mock handler and updated network support |
| .github/workflows/ci.yml | Simplified CI workflow to run pnpm commands directly |
| pnpm-workspace.yaml | Added workspace configuration with build dependencies |
| mise.toml | Removed pnpm alias configuration |
| .husky/commit-msg | Added commit message linting hook |
| .changeset/young-poets-grin.md | Added changeset for patch release |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Philippoes
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the API schemas and refines the SDK by removing legacy yield balances endpoints and adding new query/filter capabilities. It also improves CI/CD and commit workflow configuration, and adds support for a new network type. Below are the most important changes grouped by theme.
API Schema and SDK Improvements
src/api/index.tsandsrc/api/schemas/index.ts, simplifying the API and type definitions. [1] [2] [3] [4] [5] [6] [7] [8]YieldQueryDtofor multi-network, multi-type, multi-token, and multi-provider filtering, plus support for sorting yields by status. [1] [2] [3] [4] [5] [6] [7]hyperevmnetwork across all relevant schema files, enabling compatibility with this new network type. [1] [2] [3] [4] [5] [6]Build and Workspace Configuration
.github/workflows/ci.ymlto runpnpmcommands directly instead of usingmise x, simplifying the CI workflow.pnpm-workspace.yamlto specifyonlyBuiltDependencies, improving build performance and dependency management.mise.tomlby removing thepnpmalias configuration.Developer Workflow
.husky/commit-msgto enforce commitlint checks on commit messages.Release Management