Conversation
🦋 Changeset detectedLatest commit: fa4ae6d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces expanded API capabilities for yield and transaction management, focusing on schema updates and dependency improvements. The changes add new transaction submission functionality, enhance filtering options for yield queries, and improve schema flexibility to better handle real-world data variations.
- Added a new
submitTransactionendpoint for directly submitting signed transactions to the blockchain - Expanded yield filtering capabilities with type, cooldown/warmup period, and name search options
- Made validator and yield statistics fields optional/nullable to accommodate data variability
Reviewed Changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/api/index.ts | Added submitTransaction endpoint and result type |
| src/api/schemas/submitTransactionDto.ts | New DTO for transaction submission requests |
| src/api/schemas/transactionsControllerSubmitTransaction*.ts | Error response schemas for transaction submission |
| src/api/schemas/yieldsControllerGetYieldsType.ts | New enum for yield type filtering |
| src/api/schemas/yieldQueryDtoType.ts | Yield type filter for query DTOs |
| src/api/schemas/yieldsControllerGetYieldsParams.ts | Enhanced params with new filtering options |
| src/api/schemas/yieldQueryDto.ts | Updated query interface with additional filters |
| src/api/schemas/yieldMetadataDto.ts | Added maintenance, deprecation, and standards fields |
| src/api/schemas/eRCStandards.ts | New enum for supported ERC standards |
| src/api/schemas/validatorDto.ts | Made fields optional and added subnet-related properties |
| src/api/schemas/yieldStatisticsDto.ts | Made all fields optional and nullable |
| src/api/index.msw.ts | Updated mock handlers to reflect schema changes |
| package.json | Updated development dependencies |
| biome.json | Improved include/exclude patterns |
| .changeset/common-ghosts-share.md | Added changeset for the release |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| (typeof YieldsControllerGetYieldsType)[keyof typeof YieldsControllerGetYieldsType]; | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-redeclare | ||
| export const YieldsControllerGetYieldsType = { |
There was a problem hiding this comment.
The type and const object have identical names, which creates a naming collision. Consider renaming the const object to something like YieldsControllerGetYieldsTypeValues to distinguish it from the type.
| export const YieldsControllerGetYieldsType = { | |
| (typeof YieldsControllerGetYieldsTypeValues)[keyof typeof YieldsControllerGetYieldsTypeValues]; | |
| // eslint-disable-next-line @typescript-eslint/no-redeclare | |
| export const YieldsControllerGetYieldsTypeValues = { |
| (typeof YieldQueryDtoType)[keyof typeof YieldQueryDtoType]; | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-redeclare | ||
| export const YieldQueryDtoType = { |
There was a problem hiding this comment.
The type and const object have identical names, which creates a naming collision. Consider renaming the const object to something like YieldQueryDtoTypeValues to distinguish it from the type.
| export const YieldQueryDtoType = { | |
| (typeof YieldQueryDtoTypeValues)[keyof typeof YieldQueryDtoTypeValues]; | |
| export const YieldQueryDtoTypeValues = { |
| export type ERCStandards = (typeof ERCStandards)[keyof typeof ERCStandards]; | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-redeclare | ||
| export const ERCStandards = { |
There was a problem hiding this comment.
The type and const object have identical names, which creates a naming collision. Consider renaming the const object to something like ERCStandardsValues to distinguish it from the type.
| export const ERCStandards = { | |
| export type ERCStandards = (typeof ERCStandardsValues)[keyof typeof ERCStandardsValues]; | |
| // eslint-disable-next-line @typescript-eslint/no-redeclare | |
| export const ERCStandardsValues = { |
3f68a23 to
3e3e2e0
Compare
3e3e2e0 to
f2ea79e
Compare
f2ea79e to
fa4ae6d
Compare
This pull request introduces several new features and schema updates to the SDK, focusing on expanding API capabilities for yield and transaction management, as well as improving schema flexibility and consistency. The changes include new API endpoints, additional filtering options, enhanced schema definitions, and dependency updates.
API Enhancements:
submitTransactionendpoint for submitting signed transactions, along with its DTO and result types. (src/api/index.ts,src/api/schemas/submitTransactionDto.ts, [1] [2] [3]src/api/schemas/transactionsControllerSubmitTransaction401.ts,src/api/schemas/transactionsControllerSubmitTransaction429.ts,src/api/schemas/transactionsControllerSubmitTransaction500.ts, [1] [2] [3] [4]Schema and Filtering Improvements:
src/api/schemas/yieldQueryDto.ts,src/api/schemas/yieldQueryDtoType.ts,src/api/schemas/yieldsControllerGetYieldsParams.ts,src/api/schemas/yieldsControllerGetYieldsType.ts, [1] [2] [3] [4] [5]YieldMetadataDtoto include new fields:underMaintenance,deprecated, andsupportedStandards(with a newERCStandardsenum). (src/api/schemas/yieldMetadataDto.ts,src/api/schemas/eRCStandards.ts, [1] [2]Schema Flexibility and Consistency:
ValidatorDtoandYieldStatisticsDtooptional or nullable to better reflect real-world data variability. (src/api/schemas/validatorDto.ts,src/api/schemas/yieldStatisticsDto.ts, [1] [2]src/api/schemas/validatorQueryDto.ts,src/api/schemas/yieldQueryDto.ts,src/api/schemas/yieldsControllerGetYieldValidatorsParams.ts, [1] [2] [3]Dependency and Config Updates:
biome.jsoninclude/exclude patterns for better project hygiene. (package.json,biome.json, [1] [2]Release and Documentation:
.changeset/common-ghosts-share.md, .changeset/common-ghosts-share.mdR1-R5)