ROX-29043 Build arm64 versions of CI images for build and test#225
ROX-29043 Build arm64 versions of CI images for build and test#225robbycochran wants to merge 9 commits intomainfrom
Conversation
|
@tommartensen what do you think about keepking TARGETARCH as is? See my comment here https://github.com/stackrox/rox-ci-image/pull/225/files#r2168074052 |
Agree. I resolved those comments, but there is still one suggestion: https://github.com/stackrox/rox-ci-image/pull/225/files#r2166203025 |
4829124 Add arm64 build and test images 591a0a4 matrix f308f72 format 2bd6ed1 arm runners c874046 include 029d72f failfastfalse d088cd2 arch tags c02366d create multiarch manifest 254e179 space 782ab48 handle 5432a37 fix 14f0332 target 2cfd390 flip 48f9992 amd64 01eddcb push arch 9a6b3ff quotes 407c401 update 4e30669 - 5e4456d flav
Co-authored-by: Tom Martensen <tmartens@redhat.com>
davdhacs
left a comment
davdhacs
left a comment
There was a problem hiding this comment.
+1
(my question doesn't require a change)
images/stackrox-test.Dockerfile
Outdated
| amd64) echo "TARGETARCH_ALT=x86_64" ;; \ | ||
| arm64) echo "TARGETARCH_ALT=aarch64" ;; \ | ||
| *) echo "Unsupported $TARGETARCH"; exit 1;; \ | ||
| esac > /arch.env |
There was a problem hiding this comment.
Could TARGETARCH_ALT be added as another ARG/ENV variable instead of stored in a file, or does it need to be visible in a file for another reason than re-use in following steps?
There was a problem hiding this comment.
I went ahead and made this change, the file storage isn't necessary.
|
The ui-image build failure is due to a broken postgres package signature (pgdg-packaging/pgdg-rpms#64). |
3 participants
Description
images/stackrox-build.Dockerfileandimages/stackrox-test.Dockerfileto support downloading and installing needed libraries for arm64.Updates / Issues
Changes to build image:
Changes to test image:
Not migrated:
Testing