ROX-29469: New check flagging use of deprecated fields in SecuredCluster CR#1081
Draft
mclasmeier wants to merge 7 commits intomainfrom
Draft
ROX-29469: New check flagging use of deprecated fields in SecuredCluster CR#1081mclasmeier wants to merge 7 commits intomainfrom
mclasmeier wants to merge 7 commits intomainfrom
Conversation
mclasmeier
force-pushed
the
mc/stackrox-crd-checks-2
branch
from
b676cbf to
fe0f138
Compare
added 7 commits
January 14, 2026 17:44
8b9c15d0949407c365c6b09fc1a924a4ac361ec3 (not yet on master).
For the purpose of testing this change until the upstream CRD is enriched with "deprecated" struct tags.
mclasmeier
force-pushed
the
mc/stackrox-crd-checks-2
branch
from
fe0f138 to
072150e
Compare
2 tasks
mclasmeier
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Don't merge before ROX-29469.
New check flagging use of deprecated fields in SecuredCluster CR.
This PR pulls in StackRox CRDs, currently from the PR branch stackrox/stackrox#18494. That's also the reason for the huge size of this PR.
It depends on new
deprecated:"true"Go struct tags being added to our CRD types.This PR only focuses on SecuredCluster, but a similar check+tests for the Central PR shall follow, once this has passed review.
This is the first step towards ROX-29469, focusing on situations where the user has set deprecated fields in their CR.
A second step would be to introduce a new struct tag
"hasdefault"(or similar name), which works pretty much like the"deprecated"tag.