feat(tests): miscellaneous improvements #220
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print the events a server waits in a common place to reduce code duplication.
With the addition of the autouse feature to the fact fixture the fact container is spin up and torn down on its own for every test, no need to declare explicitly.
This change replaces the ignored events for strict mode, this is more reliable, since a change to how we report events could cause us to miss the ignored event if it is reported differently. Instead, strict mode will cause tests to fail if any event that is not expected is found. We also use the new class method `Process.in_container` to simplify the definition of processes that run inside containers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a few things to our tests in an attempt to reduce the boilerplate needed and improve test maintainability (even if it is only slightly). The changes are:
server.FileActivityService.wait_events. This removes the need to print these events in every test separately.factfixture in tests and rely on theautouse=Truedecorator.Process.in_containerto make defining processes that run inside containers less verbose.strictmode the default mode for waiting on events. This is more reliable and easier than declaring events that should be ignored by hand.Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
CI is enough.