-
-
Notifications
You must be signed in to change notification settings - Fork 16
feat(stackable-operator): Support gitsync via SSH #1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only really looked at the CRD change (as the decision was accepted) and left a suggestion.
IIRC we wanted to try CRD versioning for this, sadly that will be another beast to tackle
Pls fee free to ping @Techassi, @NickLarsenNZ (or me if they are absent) if you need any help with that!
Because we should have CRD versioning in place before merging this (as otherwise it breaks v1alpha1)
edit: Oh sorry, I thought this was Waiting for review, my fault!
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Description
Prerequisite for stackabletech/airflow-operator#382.
Tested with stackabletech/airflow-operator#718.
The gitsync test in Nifi was also successfully tested with this PR.
CRD Change
See https://github.com/stackabletech/decisions/issues/68
Definition of Done Checklist
Author
Reviewer
Acceptance