Open
Conversation
f889645 to
2af0e83
Compare
Author
|
Not yet sure why CI hasn't been triggered on this repo for this PR, but on my fork it is triggered https://github.com/130s/srv_tools/actions/runs/1831022995 and failed. Obviously some code changes seem to be needed E.g. https://github.com/130s/srv_tools/runs/5160898301?check_suite_focus=true If I can find time I'd like to contribute adding patches but if anyone can do that I'm happy to take PR against my forked branch so that I can merge your changes into my PR (and you retain your commit authorship). |
a810a35 to
33eec47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a support for #24 with as less effort as possible, I think having CI do some work will be helpful.
If CI fails and I can find time to address, I can also add such changes in this PR if that's ok.