SC-XXX: Improved speed of docker image building#449
Open
SC-XXX: Improved speed of docker image building#449
Conversation
- Introduced `docker bake` as main build mechanism with fallback to `docker build` if bake is not available - Adjusted build process by utilising multistage builds and paralleling builds - Optimised cache usage by separating/moving parameters that are changed often (e.g. build hash, stamp) - Fixed bug with `docker/sdk export` when export options was ignored when `-v` option was used at the same time - Added labels for all images containing project revision, project name and SDK revision - Adjusted maintenance mode to be controlled by environment variable: SPRYKER_MAINTENANCE_MODE_ENABLED=1 docker/sdk run
…update instead of create/delete
Contributor
|
Great to see this being worked on @sprymiker. For comparison: |
…llowing parallel pushes of application images
- Removed intermediate dump-autoload as it probably takes more time than benifits for the following build
…n 0.7.1 - Upgraded syntax docker version - Removed parallelisation for fallback build (without buildx)
…ing dependencies.
…g them in cli image
Optimized pipeline and jenkins images by removing unnecessary binaries (e.g. PGSQL client if database is MYSQL)
Contributor
|
Any chances for this PR to be merged eventually @zyuzka @alexanderM91 |
Collaborator
Hi @oleg-glushak, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Inspired by https://github.com/spryker/docker-sdk/tree/onsteroids. Thank you, @oleg-glushak!
Difference:
docker build bakecovers this OOTBP.S. Image size concern was not fully considered. Additional activities measurements are needed, including changes in spryker/docker-php as a separate topic.
Related resources
Change log
Improved speed of docker image building
docker bakeas the primary build mechanism with a fallback todocker buildif bake is not availabledocker/sdk exportwhen export options were ignored when-voption was used at the same timeSPRYKER_MAINTENANCE_MODE_ENABLED=1 docker/sdk runChecklist