Add the ability to set up a custom Xdebug host IP#255
Open
peresypkin wants to merge 30 commits intomasterfrom
Open
Add the ability to set up a custom Xdebug host IP#255peresypkin wants to merge 30 commits intomasterfrom
peresypkin wants to merge 30 commits intomasterfrom
Conversation
6a7c260 to
4341d2d
Compare
4341d2d to
2cc5c58
Compare
|
Hi all, this feature is also needed when remote debugging in a container, as I'm used to do it with VSC (Visual Studio Code). Currently I workaround by manually setting Thank you for this code contribution! Stephan |
2cc5c58 to
af9b1e6
Compare
af9b1e6 to
8709ca9
Compare
Contributor
|
Hi @alexanderM91 and @sprymiker, this faeture is quite usefull for us in my company. Thank you, |
8709ca9 to
3129dd2
Compare
3129dd2 to
f1ede98
Compare
f1ede98 to
66c8b46
Compare
cfa7421 to
239915b
Compare
239915b to
5a2fae6
Compare
5a2fae6 to
d296594
Compare
added 2 commits
August 12, 2022 10:18
* Add the ability to set up a custom Xdebug host IP for the case when Docker is deployed inside a virtual machine (e.g. Vagrant + VirtualBox) for local development.
d296594 to
13deb2f
Compare
added 12 commits
September 20, 2022 08:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Docker is deployed inside a virtual machine (e.g. Vagrant + VirtualBox)
for local development.
Change log
SPRYKER_CUSTOM_XDEBUG_HOST_IPvariable has been added togenerator/src/templates/deploy.bash.twig. Its value gets set in the deployment configuration as follows:SPRYKER_XDEBUG_HOST_IPvariable is set based on the value ofSPRYKER_CUSTOM_XDEBUG_HOST_IP. If it's not defined, the default logic to get the IP of the host is used.Checklist