DATAREST-524 Invoke validators registered with composite bean names#2048
Open
laskaridis wants to merge 1 commit intospring-projects:mainfrom
laskaridis:DATAREST-524
Open
DATAREST-524 Invoke validators registered with composite bean names#2048laskaridis wants to merge 1 commit intospring-projects:mainfrom laskaridis:DATAREST-524
laskaridis wants to merge 1 commit intospring-projects:mainfrom
laskaridis:DATAREST-524
Conversation
The ValidatingRespositoryEventListener will currently ignore any validator that has been registered under a composite key consisting of the event name post-fixed by the model name and the keyword "Validator". This does not allow executing validator beans registered using the "@component" or "@bean" annotations, which should be possible according to the reference guide. This happens because the code will only look for validators registered using the event name as a key only. To fix this, I added a second lookup (if the previous fails) by a composite key name that follows the semantics described previously. See: https://docs.spring.io/spring-data/rest/docs/3.5.3/reference/html/#validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ValidatingRespositoryEventListener will currently ignore any
validator that has been registered under a composite key consisting of
the event name post-fixed by the model name and the keyword "Validator".
This does not allow executing validator beans registered using the
"@component" or "@bean" annotations, which should be possible according
to the reference guide.
This happens because the code will only look for validators registered
using the event name as a key only. To fix this, I added a second lookup
(if the previous fails) by a composite key name that follows the
semantics described previously.
See: https://docs.spring.io/spring-data/rest/docs/3.5.3/reference/html/#validation