This repository was archived by the owner on Feb 6, 2018. It is now read-only.
Open
Conversation
Collaborator
|
Yes, the endpoints should be more configurable. We will review your pull request. |
Author
|
Are there any updates on this? |
|
I'd like to comment that although it's 'nice' that the endpoint urls are 'derived' from some base value and you prepend 'search' and add the region and base AWS url, you should make the entire url configurable. CloudSearch only allows IP based security, and our app runs on heroku which doesn't have a static ip. To work around it we are currently running our doc updates through a proxy with a static ip. Therefore, our doc upload url isn't even the standard url. Making the url configurable and allowing you to point to any url you want would be more flexible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are now developing Groonga CluodSearch, an open source implementation of Amazon CloudSearch.
http://gcs.groonga.org/
Groonga CloudSearch can work with aws_cloud_search by monkey patching
that directs the requests toward the host running Groonga CloudSearch instead of Amazon CloudSearch.
http://gcs.groonga.org/blog/2012/07/25/work-with-aws-cloud-search-gem/
It would be great if aws_cloud_search can pick the base domain name of doc and search endpoints and URL of configuration endpoint. With this patch, we can initiate AWSCloudSearch::CloudSearch object like below:
How do you think? I'd like to hear your thought.