Implement cursor context finder for LSP #1439
Conversation
- Add `analysis` module with `find_node_at_offset` function. - Modify parser to allow missing identifier in dot access (e.g. `sys.`) to support autocomplete. - Add `Node` enum to represent AST nodes (Stmt or Expr). - Add tests for cursor finding.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
|
Run |
Ran |
- Add `analysis` module with `find_node_at_offset` function. - Modify parser to allow missing identifier in dot access (e.g. `sys.`) to support autocomplete. - Add `Node` enum to represent AST nodes (Stmt or Expr). - Add tests for cursor finding. - Run `cargo fmt`.
|
@hulto this will be helpful for our lsp server (vscode extension). low effort ai pr |
Implemented
find_node_at_offsetto find the AST node at a given cursor position. Modified the parser to tolerate missing identifiers after a dot, creating aGetAttrnode with an empty name, which allows the LSP to inspect the left-hand side for completions. Added comprehensive tests.PR created automatically by Jules for task 14534893887575898734 started by @KCarretto