Skip to content

Conversation

@alxbilger
Copy link
Contributor

@alxbilger alxbilger commented Feb 9, 2026

Main changes:

  • Input/output topology types are not checked in case the output topology is a MeshTopology. In this case, the output type is not well defined.
  • Removed the check for a topology modifier.
  • Removed the use of TetrahedronSetTopologyContainer, as we already have a link to a BaseMeshTopology. No need for specific methods in TetrahedronSetTopologyContainer.
  • Replace set of tetrahedron components by a MeshTopology in a scene to show it works.

Note that using a MeshTopology will not support dynamic change of topology. But Hexa2TetraTopologicalMapping does not support it as well.

[with-all-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request pr: enhancement About a possible enhancement labels Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant